fix: missing argument names in rb_prohibit_copy (build failure on older GCC/Clang)#99
Merged
SpringMT merged 1 commit intoSpringMT:mainfrom Mar 19, 2025
Merged
fix: missing argument names in rb_prohibit_copy (build failure on older GCC/Clang)#99SpringMT merged 1 commit intoSpringMT:mainfrom
SpringMT merged 1 commit intoSpringMT:mainfrom
Conversation
Owner
|
Thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The argument variable names of
rb_prohibit_copyintroduced in #98 are missing.This is C23-style function declarations (N2480), so it causes build failures on older versions of GCC <= 10 (and Clang <= 10) 1 with the following error:
Although this error does not occur on recent versions of GCC/Clang, it may cause build failures in slightly older environments.
This PR fixes the function declaration by explicitly specifying the argument variable names to maintain compatibility.
Footnotes
https://en.cppreference.com/w/c/23 ↩