[codex] Fix p848 CI clean-checkout assumptions#7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the p848 CI failures from the clean GitHub Actions checkout by removing two local-machine assumptions:
orp/oroutput/artifacts are absent.rg.Root Cause
The April 19
mainCI run failed afternpm cisucceeded because the test suite expected local/generated artifacts that are intentionally ignored by git:orp/research/...output/frontier-engine-local/.../SIX_PREFIX_*_FAMILY_MENU.jsonThe same p848 test file also exercised scripts that shell out to
rg, which is available on the development machine but not guaranteed in the GitHub Actions runner.Impact
This blocked repo CI and skipped the CI
npm pack --dry-runstep. It did not appear to block normal npm installs oferdos-problems@0.3.8, but clean-checkout contributors and CI could fail on the p848 audit surface.Validation
node --test test/p848-282-alignment-obstruction-packet.test.jsenv PATH=/tmp/erdos-node-only-bin node --test test/p848-282-alignment-obstruction-packet.test.jsnpm testenv PATH=/tmp/erdos-node-only-bin:/usr/bin:/bin node --testThe final full-suite no-
rgrun passed238/238tests.