feat(cli): print tx signature before send for hardware wallet verification#179
Closed
jkbpvsc wants to merge 1 commit intoSquads-Protocol:mainfrom
Closed
feat(cli): print tx signature before send for hardware wallet verification#179jkbpvsc wants to merge 1 commit intoSquads-Protocol:mainfrom
jkbpvsc wants to merge 1 commit intoSquads-Protocol:mainfrom
Conversation
…ation Print the transaction signature up front in send_and_confirm_transaction so users signing with a Ledger or other hardware wallet can cross-check the hash shown on-device against the one printed by the CLI. Previously the signature was only printed after confirmation succeeded, which meant it was impossible to verify before signing and was lost entirely on failure or RPC timeout.
|
@jkbpvsc is attempting to deploy a commit to the squads Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Already handled in #172 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
send_and_confirm_transactionbefore the RPC call, so users signing with a Ledger or other hardware wallet can cross-check the hash shown on-device against the one printed by the CLI.send_and_confirmreturnedOk, which meant (a) it couldn't be verified before signing and (b) it was lost entirely on preflight failure or RPC timeout, leaving no way to look the tx up.multisig-create,vault-transaction-*,config-transaction-*,proposal-vote,initiate-*,claim-rent,program-config-init, …).