Skip to content

DRAFT: Suggested rules in repo view#78

Open
karlclement wants to merge 4 commits into
developmentfrom
karl/suggested-rules
Open

DRAFT: Suggested rules in repo view#78
karlclement wants to merge 4 commits into
developmentfrom
karl/suggested-rules

Conversation

@karlclement

Copy link
Copy Markdown
Contributor

CleanShot 2024-11-13 at 15 27 49
Screenshot 2024-11-13 at 3 28 24 PM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 13, 2024

Copy link
Copy Markdown

Deploying squire-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: 968f78a
Status: ✅  Deploy successful!
Preview URL: https://50ad0e80.squire-web.pages.dev
Branch Preview URL: https://karl-suggested-rules.squire-web.pages.dev

View logs

@karlclement karlclement changed the title Suggested rules in repo view DRAFT: Suggested rules in repo view Nov 13, 2024

&.borderColor {
@apply border-l-2;
margin-left: 0;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apply ml-0 ?

@derricks-squire derricks-squire Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request summary created by Squire AI

Summary

This pull request enhances the user interface and functionality of the repository view. It introduces the 'addressSuggestion' function in '+page.svelte' to handle rule acceptance/rejection and updates the rule display logic with additional styling. The ListItem component in 'ListItem.svelte' receives improvements with twMerge for class merging and a new 'borderColor' prop, along with refactored CSS. The Tailwind configuration is updated with a new 'icey' color palette, and the button styles in 'buttons.scss' are updated with a new 'btn-dark' class and hover transitions.

b5816fa...968f78a

File Summary

File Changes:

  • ListItem.svelte: Added twMerge for class merging and introduced borderColor prop. Refactored CSS classes for better readability and maintainability.
  • buttons.scss: Updated hover transition and added new btn-dark class with specific styles for dark buttons.
  • +page.svelte: Added addressSuggestion function for accepting/rejecting rules and restructured rule display logic with additional styling for custom rules.
  • tailwind.config.ts: Introduced new color palette 'icey' with various shades to the Tailwind configuration.

b5816fa...968f78a

@saumilptl

Copy link
Copy Markdown

/squire review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants