Conversation
| cmake --build . | ||
| - name: Commit files | ||
| run: | | ||
| git config --local user.name "dmarx" |
There was a problem hiding this comment.
This should not override the default action user.
There was a problem hiding this comment.
this will run into the same issue described in the sdk CI: pretty sure if I don't configure a user, it'll just complain. How do we make sure a default action user is configured? or should we just choose a consistent username for gh actions?
There was a problem hiding this comment.
Same as there:
You can use github.actor from the github context https://docs.github.com/en/actions/learn-github-actions/contexts#github-context.
| - name: CMake & Build | ||
| run: | | ||
| cmake . | ||
| cmake --build . |
There was a problem hiding this comment.
This needs to run the clean target first as sometimes it seems to skip some files during build, probably something that can be fixed with the cmake configuration but until it is need to clean before build.
| node-version: "16" | ||
| #- name: Install additional tooling | ||
| # run: | | ||
| # sudo apt install -y protobuf-compiler-grpc libgrpc6 libgrpc++1 |
There was a problem hiding this comment.
Remove these commented out items.
| run: | | ||
| git config --local user.name "dmarx" | ||
| git add ./gooseai/* | ||
| git commit -m "Updated protobuf files" |
There was a problem hiding this comment.
Possibly could use a better commit message as this sounds more like updating the proto files to me.
There was a problem hiding this comment.
yup, that was a copypaste from the sdk CI, my b
| name: Build protobuf stubs | ||
|
|
||
| on: | ||
| push: |
There was a problem hiding this comment.
If left on all branches then it will regenerate in work branches which I don't think is ideal.
| module github.com/stability-ai/api-interfaces/gooseai | ||
|
|
||
| go 1.18 | ||
| go 1.17 |
There was a problem hiding this comment.
We want to keep this at go 1.18
There was a problem hiding this comment.
yeah I have no idea why that changed and it freaked me out a bit when I first saw it. might need to force a version in one of the CI actions
| // versions: | ||
| // protoc-gen-go v1.26.0 | ||
| // protoc v3.21.4 | ||
| // protoc v3.12.2 |
There was a problem hiding this comment.
Seems like this is using the older protoc, would like to stay with the more recent version.
arsenetar
left a comment
arsenetar
left a comment
There was a problem hiding this comment.
Some cleanup as commented, and needs to run clean before build.
|
Kudos, SonarCloud Quality Gate passed!
|
|
@dmarx Is this OBE? Are we goin to address @arsenetar's comments? |
|
@dmarx Ping. |
3 participants
re-build protobuf stubs on change.
to do: