Conversation
johnsabath
force-pushed
the
js/estimate-cost-operation
branch
from
7cb6470 to
13b8567
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
| service GenerationService { | ||
| rpc Generate (Request) returns (stream Answer) {}; | ||
| rpc ChainGenerate (ChainRequest) returns (stream Answer) {}; | ||
| rpc EstimateCost (Request) returns (EstimateCostResponse) {}; |
There was a problem hiding this comment.
Is there a reason to break from the Answer pattern here? I suggest against this. We have metadata around this.
There was a problem hiding this comment.
My initial impression was that there was a fair bit of additional risk introduced if I modified the generation logic to support a "dry run" / "cost estimation" mode where an Answer could come back without any image artifacts, but that's largely due to me being unfamiliar with the code and not having a test case safety net to lean on.
I'll take another stab at this if maintaining that pattern is the goal.
|
New PR: #35 |
2 participants
There are some unexpected diffs due to some of the files being generated with newer versions of protoc previously, but I don't believe that the changes will have an affect on the runtime behavior. The outputs in this MR were generated by the docker build process. My hope is that these unintentional diffs will no longer be an issue once building via docker is established as the norm.