Skip to content

Logic checks ethBalance < BigInt(fee) ignores gas costs #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aniket866 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Logic checks ethBalance < BigInt(fee) ignores gas costs #126

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce7d552
fixing-balance-check
aniket866 Feb 28, 2026
e01931f
Code rabbit follow-up
aniket866 Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions frontend/src/page/ReceivedInvoice.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,19 +234,25 @@ function ReceivedInvoice() {
};

// UNIFORM BALANCE CHECK
const checkBalance = async (tokenAddress, amount, symbol, signer) => {
const checkBalance = async (tokenAddress, amount, symbol, signer, invoiceCount = 1) => {
const userAddress = await signer.getAddress();

// Add a reasonable buffer for gas fees (e.g., 0.002 ETH).
// You can adjust this value depending on the typical network gas costs you expect.
const gasBuffer = ethers.parseEther("0.002");

if (tokenAddress === ethers.ZeroAddress) {
const balance = await signer.provider.getBalance(userAddress);

// Include gas buffer in the total required ETH calculation
const totalRequired =
ethers.parseUnits(amount.toString(), 18) + BigInt(fee);
ethers.parseUnits(amount.toString(), 18) + (BigInt(fee) * BigInt(invoiceCount)) + gasBuffer;

if (balance < totalRequired) {
const requiredEth = ethers.formatEther(totalRequired);
const availableEth = ethers.formatEther(balance);
throw new Error(
`Insufficient ETH balance. Required: ${requiredEth} ETH, Available: ${availableEth} ETH`
`Insufficient ETH balance. Required: ~${Number(requiredEth).toFixed(4)} ETH (including gas), Available: ${Number(availableEth).toFixed(4)} ETH`
);
Comment thread
aniket866 marked this conversation as resolved.
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
} else {
Expand All @@ -263,11 +269,15 @@ function ReceivedInvoice() {
}

const ethBalance = await signer.provider.getBalance(userAddress);
if (ethBalance < BigInt(fee)) {
const requiredEthFee = ethers.formatEther(fee);

// Add gas buffer for ERC20 payments as well (to cover approval/payment gas + network fee)
const totalEthRequired = (BigInt(fee) * BigInt(invoiceCount)) + gasBuffer;

if (ethBalance < totalEthRequired) {
const requiredEthFee = ethers.formatEther(totalEthRequired);
const availableEth = ethers.formatEther(ethBalance);
throw new Error(
`Insufficient ETH for fees. Required: ${requiredEthFee} ETH, Available: ${availableEth} ETH`
`Insufficient ETH for fees and gas. Required: ~${Number(requiredEthFee).toFixed(4)} ETH, Available: ${Number(availableEth).toFixed(4)} ETH`
);
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
}
Expand Down Expand Up @@ -515,7 +525,8 @@ function ReceivedInvoice() {
group.tokenAddress,
group.totalAmount,
group.symbol,
signer
signer,
group.invoices.length
);
} catch (error) {
setPaymentError(error.message);
Expand Down