Support for arbitrary mappings and immutable dicts as inputs for dict nodes#46
Merged
StableLlama merged 10 commits intoStableLlama:mainfrom Mar 22, 2026
Merged
Conversation
b31b20a to
7d280c6
Compare
Contributor
Author
|
I see the failed test. I'll investigate it later. |
0535ce6 to
cc8a24e
Compare
Contributor
Author
Ready for review/merge. |
cc8a24e to
d26e633
Compare
54e92f0 to
a69162c
Compare
a69162c to
eee342a
Compare
…termediate dict -> preserve type
eee342a to
b90ca06
Compare
Contributor
Author
|
I had to make a few rebases and force-pushes in order to run the existing github workflows myself. The branch now also contains small QoL improvements to the existing workflows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the node pack doesn't work with custom mapping-like classes.
In my node pack, I rely on
frozendictto ensure that other poorly coded nodes down the line can't accidentally change the contents of a connected input dict coming from my node. And for any dict-related work, I recommend this "Basic Data Handling" pack instead of reinventing the wheel for the 100th time.So, I made all the dict-related nodes to work in general case: with ANY dict-like objects, and not just with the built-in
dictitself.