Change --cmax default to 100. Infinity is just too large#4126
Merged
tlimoncelli merged 2 commits intomainfrom Mar 3, 2026
Merged
Change --cmax default to 100. Infinity is just too large#4126tlimoncelli merged 2 commits intomainfrom
tlimoncelli merged 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
We're seeing stalls with "--cmax 999" (the default) but not with --cmax 100. This might be a Cloudflare SDK issue, or possibly a local firewall getting overly stressed.
Resolution
Change the default to 100. It shouldn't make a large performance difference, and sites with large numbers of domains probably don't use the default either.