fix(ci): skip mock server install in release workflow [ENG-11910] #111
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the Release Please workflow failure by adding a mechanism to skip MCP mock server dependency installation in workflows that don't need it.
Changes:
- Added
skip-mock-serverinput parameter to the setup-nix action to control mock server dependency installation - Configured the release workflow to skip mock server installation since it doesn't run tests
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/actions/setup-nix/action.yaml |
Added new skip-mock-server input parameter and updated the conditional logic to skip mock server installation when either skip-uv-sync or skip-mock-server is true |
.github/workflows/release.yaml |
Configured the setup-nix action call to skip mock server installation by setting skip-mock-server: "true" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
skip-mock-serverinput to setup-nix action to skip MCP mock server dependencies installationskip-mock-server: "true"in release workflow since it doesn't run testsProblem
Release Please workflow failed because
pnpmwas not installed (onlyuv ty justare in the default tools), but the action tried to runpnpm installfor the mock server.Test plan
Summary by cubic
Fixes Release Please failures by skipping MCP mock server dependency install in release runs. Adds a skip-mock-server flag to setup-nix and enables it in the release workflow so releases don’t require pnpm (unblocking ENG-11910).
Written for commit 9fb786a. Summary will update on new commits.