refactor(ci): remove unused skip-mock-server option from setup-nix #116
+1
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The skip-mock-server option was only used by the release workflow, which now uses nix develop directly instead of the setup-nix action. This simplifies the action by removing the unused input.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to remove the skip-mock-server input from the setup-nix GitHub Action, claiming it is no longer used after the release workflow was updated in PR #115 to use nix develop directly.
Changes:
- Removed
skip-mock-serverinput definition from the setup-nix action - Simplified the conditional check for installing MCP mock server dependencies to only check
skip-uv-sync
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
9
to
11
| description: "Skip uv sync step (useful for jobs that do not need Python dependencies)" | ||
| required: false | ||
| default: "false" |
There was a problem hiding this comment.
Removing the skip-mock-server input will break the release workflow. The file .github/workflows/release.yaml still uses this input on line 31 with skip-mock-server: "true". This reference needs to be removed from the release workflow before this input can be safely removed from the action definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
skip-mock-serverinput from setup-nix actionTest plan
Summary by cubic
Removed the unused skip-mock-server input from the setup-nix action and simplified the install step to only check skip-uv-sync. The release workflow now uses nix develop, so this cleans up CI and removes a misleading option.
Written for commit 80abfac. Summary will update on new commits.