ci(release): update uv.lock via workflow instead of release-please #120
+28
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The release-please generic updater cannot reliably identify the correct version line in uv.lock (too many packages have version fields). Instead, run `uv lock` after release-please creates/updates the PR to regenerate the lockfile with the updated pyproject.toml version. - Remove extra-files config from release-please - Add workflow steps to checkout release branch, run uv lock, and commit
ryoppippi
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the uv.lock update mechanism during releases by moving the update logic from release-please's generic updater (which cannot reliably identify the correct version line in uv.lock) to a dedicated workflow step that runs uv lock after the release PR is created.
Changes:
- Removed
extra-filesconfiguration from.release-please-config.jsonthat attempted to update uv.lock using the generic updater - Added workflow steps to checkout the release PR branch, run
uv lock, and commit changes when needed
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.release-please-config.json |
Removed non-functional extra-files configuration for uv.lock |
.github/workflows/release.yaml |
Added steps to update uv.lock by running uv lock when release PR is created/updated |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
extra-filesconfig from release-please (generic updater doesn't work for uv.lock)The release-please generic updater cannot reliably identify the correct version line in uv.lock since many packages have version fields. Instead, the workflow now runs
uv lockafter release-please creates/updates the PR.Test plan
Summary by cubic
Move uv.lock updates from release-please to the release workflow. The release job now checks out the PR branch, runs uv lock, and commits changes so the lockfile matches the bumped version.
Written for commit 3ca1628. Summary will update on new commits.