refactor(release): remove redundant version update step #122
+0
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release-please already updates __init__.py version in the release PR, making the update-version script and workflow step redundant. - Remove update-version step from release workflow - Remove update-version target from justfile - Delete scripts/update_version.py
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the release process by removing a redundant version update step that is already handled by release-please.
Changes:
- Remove
scripts/update_version.py, which manually synced__init__.__version__and refresheduv.lock. - Remove the
update-versionrecipe fromjustfile. - Remove the "Update version in init.py" step from the release GitHub Actions workflow.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
scripts/update_version.py |
Deletes the custom version-sync script now made redundant by release-please. |
justfile |
Removes the update-version task that invoked the deleted script. |
.github/workflows/release.yaml |
Removes the post-release step that ran just update-version, relying on release-please and the existing uv.lock update step instead. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update version in __init__.pystep from release workflowupdate-versiontarget from justfilescripts/update_version.pyRelease-please already updates
__init__.pyversion in the release PR (see #117), making this step redundant.Test plan
__init__.pyversion updateSummary by cubic
Removed the redundant version update step from the release workflow and tooling. Release-please already updates init.py, so this removes duplicate logic.
Written for commit 6ec7908. Summary will update on new commits.