Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
=======================================
Coverage 71.88% 71.88%
=======================================
Files 4 4
Lines 32 32
=======================================
Hits 23 23
Misses 9 9
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
PSchmiedmayer
approved these changes
Jan 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add
@available(*, noasync)attribute♻️ Current situation & Problem
changes the
@ThreadLocalmacro to annotate the get/set accessors it defines as@available(*, noasync).the reason for this change is that the ThreadLocal mechanism completely does not work in async code, since any suspension point might result in the function switching to a different thread.
the reason why we weren't already doing this, is that i wasn't aware of the existence of this attribute.
⚙️ Release Notes
@ThreadLocalmacro now are marked as@available(*, noasync).📚 Documentation
the fact that the mechanism shouldn't be used in async code already was explicitly documented
✅ Testing
no new tests; existing tests are adjusted
(i tried writing a test to check that a program that accesses an
@ThreadLocalvariable from an async function fails to compile, but as it turns out you can only test the output a macro will produce, but not for any downstream compilation errors...)Code of Conduct & Contributing Guidelines
By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: