Skip to content

ModifierTooltip#488

Merged
trulyno merged 9 commits intoTheta-1-Mainfrom
ModifierTooltip
May 1, 2026
Merged

ModifierTooltip#488
trulyno merged 9 commits intoTheta-1-Mainfrom
ModifierTooltip

Conversation

@LuziferSenpai
Copy link
Copy Markdown
Contributor

@LuziferSenpai LuziferSenpai commented Apr 30, 2026

  • Complete Rework of tooltips for most multis
  • Added some missing entries into the addedByStarT.js file
  • Alot of cleanup

@LuziferSenpai LuziferSenpai marked this pull request as ready for review April 30, 2026 23:14
Copy link
Copy Markdown
Contributor

@UltraPuPower UltraPuPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There do seem to be some discrepancies

there are some multi's with missing lang keys:

  • implosion compressor
  • multi smelter
  • distillation tower
  • vacuum freezer
  • assembly line
    These are "artifacts", fix by removing l49-68 from tooltips.js

The macerator is getting a special available recipe tooltip from tooltips,js l86-89, why is this necessary? (It seems to be related to the pulverizer mode, but doesn't the available recipes collection happen dynamically?)

A lot of multiblocks with single recipe types don't have an available recipe types tooltip.

There are 2 "1 energy hatch tooltips" (e.g. Large assembling factory and large KubeJS multi's), I personally prefer the assembling one. Also, this seems like a capability, perhaps but it in the capability tab

Breaker lines appear on some multi's without anything above:

  • Bacterial Synthesizer

You have said that you ignored Threading and steam parallels on purpose, but I do think they should be added


"block.gtceu.rock_filtrator.tooltip.0": "§7A multiblock that can sieve through gravel and sand more precisely than a basic sieve could ever achieve, uncovering the gems hidden inside.",
"block.gtceu.rock_filtrator.tooltip.1": "Can only have §bone§r Energy Hatch",
"block.gtceu.rock_filtrator.tooltip.1": "",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we keeping this empty line?
Not the only one btw

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To space out the text below a bit

"block.gtceu.supreme_plasma_turbine.tooltip.1": "§7A massive turbine capable of being boosted consuming extreme quantities of fuel for extreme quantities of power.",
"block.gtceu.supreme_plasma_turbine.tooltip.2": "§8-----------------------------------",
"block.gtceu.supreme_plasma_turbine.top.0": "§3§lBoosted Large Plasma Turbine",
"block.gtceu.supreme_plasma_turbine.top.1": "§7A massive turbine capable of being boosted consuming extreme quantities of fuel for extreme quantities of power.",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.top. instead of .tooltip.?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because its used in both turbines, same as the .bottom

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what both turbines? This is only on the supreme turbine.

Also I still don't understand why that should change it from tooltip.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both Boosted. There are two.

@LuziferSenpai
Copy link
Copy Markdown
Contributor Author

A lot of multiblocks with single recipe types don't have an available recipe types tooltip.

Because thats how truly wanted it.
He didnt want it for single recipe type machines.

There are 2 "1 energy hatch tooltips" (e.g. Large assembling factory and large KubeJS multi's), I personally prefer the assembling one. Also, this seems like a capability, perhaps but it in the capability tab

Because the large assembling factory is gtm code, the others is kubejs.

Breaker lines appear on some multi's without anything above:

  • Bacterial Synthesizer

Because a description is missing

You have said that you ignored Threading and steam parallels on purpose, but I do think they should be added

Threading is there, its at the bottom.
It would be to much as a modifier description I think.

There do seem to be some discrepancies

there are some multi's with missing lang keys:

  • implosion compressor
  • multi smelter
  • distillation tower
  • vacuum freezer
  • assembly line
    These are "artifacts", fix by removing l49-68 from tooltips.js

Fixed

@UltraPuPower
Copy link
Copy Markdown
Contributor

Because the large assembling factory is gtm code, the others is kubejs.

so can you adjust it so that they are all using the same one? just switch the KJS ones to GT ones

@UltraPuPower
Copy link
Copy Markdown
Contributor

Because a description is missing

Is it possible to check for a description and not apply a breaker line if there isn't one?

@LuziferSenpai
Copy link
Copy Markdown
Contributor Author

Because the large assembling factory is gtm code, the others is kubejs.

so can you adjust it so that they are all using the same one? just switch the KJS ones to GT ones

Would mean adjusting the fork, so maybe for in testing.
But I wouldnt do it now.

@LuziferSenpai
Copy link
Copy Markdown
Contributor Author

Because a description is missing

Is it possible to check for a description and not apply a breaker line if there isn't one?

I can just remove the breaker.
It is manually added.

Copy link
Copy Markdown
Contributor

@trulyno trulyno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@trulyno trulyno merged commit 9160155 into Theta-1-Main May 1, 2026
2 checks passed
@trulyno trulyno deleted the ModifierTooltip branch May 1, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants