Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds vDSO (virtual Dynamic Shared Object) support to Starry OS, enabling faster system calls by providing a user-space accessible shared memory region with kernel data. The implementation integrates with the ELF loader to map vDSO pages into user address spaces and provides platform-specific initialization for aarch64 timer access.
Key changes:
- Adds new vDSO module with ELF parsing and memory mapping logic for vDSO and VVAR pages
- Integrates vDSO loading into the ELF loader pipeline during process creation
- Initializes vDSO data structures and enables timer counter access on aarch64
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| core/src/vdso.rs | New module implementing vDSO loading, ELF parsing, memory mapping, and VVAR region setup |
| core/src/mm.rs | Integrates vDSO loading into ELF loader after auxv generation |
| core/src/lib.rs | Exports the new vdso module |
| core/Cargo.toml | Adds starry-vdso dependency |
| api/src/lib.rs | Initializes vDSO data and enables aarch64 timer access, registers vDSO update callback |
| api/Cargo.toml | Adds starry-vdso dependency |
| api/src/syscall/fs/signalfd.rs | Code formatting changes (import reordering and whitespace cleanup) |
| Cargo.toml | Adds starry-vdso workspace dependency |
| Cargo.lock | Dependency lock file updates for new starry-vdso package and its transitive dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
I'm going to give some suggestions on https://github.com/Starry-OS/starry-vdso first. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A clear and concise description of what this PR does and what changes it makes.
Type of Change
Please check the applicable options:
Related Issue
Related Issue (if any): #(issue number)
Changes
Detailed description of the changes made in this PR:
cargo fmt.Elfloader.loadto load vDSO data.load_vdso_dataand related functions.Testing
Describe how you tested these changes:
cargo fmt)Checklist
Before submitting the PR, please ensure:
cargo clippycheckscargo fmtAdditional Context
Add any other context about this PR here.
Need update starry-signal version.