Fix: Circular dependencies

[chyyuu]

===
The fundamental problem
Circular dependencies: axdriver → axdma → axmm → axfs → axdriver Fix Policy
Break the two edges in the loop (axdma → axmm and axdriver → axmm) by decoupling them with crate_interface, and change axmm → axfs to optional. Change log (13 files)

1. Decouple axdma → axmm using crate_interface modules/axdma/Cargo.toml — Remove the axmm dependency and add crate_interface modules/axdma/src/lib.rs — Defines the DmaProtectIf trait (crate_interface: def_interface) modules/axdma/src/dma.rs — Replace axmm::kernel_aspace() with call_interface! (DmaProtectIf: protect_memory(...)) lock() protect(...).
2. Decouple axdriver → axmm using crate_interface modules/axdriver/Cargo.toml — Remove axmm from dyn features and dependencies modules/axdriver/src/dyn_drivers/klib.rs — Defines the IoMapIf trait, replacing axmm::iomap(...) with call_interface! (IoMapIf: iomap(...))
3. Change axmm → axfs to optional modules/axmm/Cargo.toml — Added fs feature, changing axfs/axfs-ng-vfs to optional modules/axmm/src/backend/mod.rs — Protects the cow and file modules and enum variants with #[cfg (feature = fs)]
4. Implement the interface in axruntime modules/axruntime/Cargo.toml — Added DMA feature (axdma enabled), driver-dyn supports paging, fs supports axmm?/fs modules/axruntime/src/lib.rs — Implements DmaProtectIf (axmm:kernel_aspace) and IoMapIf (axmm:iomap)
5. Feature Transmission api/axfeat/Cargo.toml — DMA feature added to axruntime/dma api/arceos_api/Cargo.toml — fs feature added to axmm? /fs
6. Fixed const compatibility issues in the new Rust toolchain ulib/axstd/Cargo.toml — Add spin dependencies
   ulib/axstd/src/io/stdio.rs — Uses spin::Lazy to statically initialize BufReader

[Copilot]

Pull request overview

This PR addresses circular dependency issues in the ArceOS module structure by breaking the dependency cycle: axdriver → axdma → axmm → axfs → axdriver. The solution employs the crate_interface pattern to decouple modules and feature flags to make filesystem dependencies optional.

Changes:

• Decoupled axdma → axmm and axdriver → axmm using crate_interface with implementations in axruntime
• Made axmm → axfs optional via feature flags to allow axmm to function without filesystem support
• Updated module versions and dependency specifications for crates.io publication readiness
• Fixed Rust toolchain compatibility issue using spin::Lazy for static initialization

Reviewed changes

Copilot reviewed 30 out of 31 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
modules/axdma/src/lib.rs	Defines DmaProtectIf interface to decouple from axmm
modules/axdma/src/dma.rs	Replaces direct axmm calls with interface calls
modules/axdma/Cargo.toml	Removes axmm dependency, adds crate_interface
modules/axdriver/src/dyn_drivers/klib.rs	Defines IoMapIf interface to decouple from axmm
modules/axdriver/Cargo.toml	Removes axmm dependency
modules/axruntime/src/lib.rs	Implements DmaProtectIf and IoMapIf interfaces
modules/axruntime/Cargo.toml	Adds dma feature and driver-dyn paging requirement
modules/axmm/src/backend/mod.rs	Guards fs-dependent backends with feature flags
modules/axmm/Cargo.toml	Makes axfs dependencies optional with fs feature
api/axfeat/Cargo.toml	Adds dma feature propagation
api/arceos_api/Cargo.toml	Adds axmm fs feature propagation
ulib/axstd/src/io/stdio.rs	Uses spin::Lazy for const initialization compatibility
ulib/axstd/Cargo.toml	Adds spin dependency
modules/axhal/src/dummy.rs	Removes kernel_aspace from dummy implementation
modules/axhal/src/mem.rs	Conditionally exports kernel_aspace
modules/axhal/src/percpu.rs	Conditionally exports percpu module
modules/axhal/Cargo.toml	Updates to version specifications for publishing
modules/axalloc/src/lib.rs	Renames allocator to axallocator
modules/axalloc/src/page.rs	Improves error handling for page allocation
modules/axalloc/Cargo.toml	Updates allocator dependency to axallocator version
modules/axtask/Cargo.toml	Updates to version specifications
modules/axconfig/src/lib.rs	Updates fallback path to local dummy.toml
modules/axconfig/dummy.toml	Adds dummy configuration for standalone builds
modules/axconfig/Cargo.toml	Adds include directive for dummy.toml and README
modules/PUBLISH_ORDER.md	Documents crates.io publication order
Cargo.toml	Updates workspace version and adds patch section
Cargo.lock	Reflects all dependency updates

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The function axmm::iomap does not exist in the axmm module. This will cause a compilation error when the driver-dyn feature is enabled. The axmm module needs to provide an iomap function that wraps the kernel address space's map_linear method to map physical addresses for IO access.

Suggested change

	#[crate_interface::impl_interface]
	impl axdriver::dyn_drivers::klib::IoMapIf for IoMapIfImpl {
	fn iomap(
	paddr: memory_addr::PhysAddr,
	size: usize,
	) -> Result<memory_addr::VirtAddr, axerrno::AxError> {
	axmm::iomap(paddr, size)
	fn iomap(
	paddr: memory_addr::PhysAddr,
	size: usize,
	) -> Result<memory_addr::VirtAddr, axerrno::AxError> {
	axmm::kernel_aspace()
	.lock()
	.map_linear(paddr, size)
	}
	#[cfg(feature = "driver-dyn")]
	#[crate_interface::impl_interface]
	impl axdriver::dyn_drivers::klib::IoMapIf for IoMapIfImpl {
	fn iomap(
	paddr: memory_addr::PhysAddr,
	size: usize,
	) -> Result<memory_addr::VirtAddr, axerrno::AxError> {
	iomap(paddr, size)

[Copilot]

Pull request overview

Copilot reviewed 38 out of 39 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 41 out of 42 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The page_table_multiarch dependency should include the "axerrno" feature for consistency with axhal and to ensure proper error type conversions. While not strictly required since axdma uses axerrno::AxError directly, it's best practice to be consistent across modules that use page_table_multiarch.

Suggested change

	page_table_multiarch = { version = "0.5" }
	page_table_multiarch = { version = "0.5", features = ["axerrno"] }

[Copilot]

Pull request overview

Copilot reviewed 50 out of 51 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

There's an inconsistency in the IRQ hook behavior between real platforms and the dummy platform. With real platforms (lines 43-48), the hook receives the IRQ number returned by handle(vector). With the dummy platform (lines 52-57), the hook receives the raw vector parameter instead. This could cause subtle bugs if code relies on the hook receiving a consistent value. Consider either:

1. Making the dummy handle() return Option<usize> and treating None as no-op, or
2. Documenting that the hook receives different values depending on the platform

[Copilot]

Pull request overview

Copilot reviewed 51 out of 52 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

axklib::mem::iomap() returns an AxResult whose error type comes from axklib’s axerrno dependency (Cargo.lock shows axklib depends on axerrno 0.1.2). Matching that error value directly against axerrno::AxErrorKind::NoMemory from this crate is very likely a type mismatch and will fail to compile. Consider matching on the actual error type returned by axklib (or extracting/converting to an error kind, e.g. via an accessor) before mapping it to OnProbeError.

[Copilot]

IoMapIf::iomap is defined to return axklib::AxResult, which (per current Cargo.lock) uses axerrno 0.1.2 via the axklib dependency. This makes the interface’s error type effectively tied to an older axerrno, and can lead to cross-crate type incompatibilities when the implementor (e.g. axruntime/axmm) uses the workspace axerrno (0.2.x). Consider redefining this interface in terms of the workspace error type (e.g. axerrno::AxError/axerrno::AxResult) or otherwise ensuring axklib and the rest of the workspace share the same axerrno version.

[Copilot]

The IoMapIf implementation returns Result<..., axerrno::AxError> from the workspace axerrno, but the trait method is declared to return axklib::AxResult in axdriver::dyn_drivers::klib. With the current dependency graph (Cargo.lock shows axklib depends on axerrno 0.1.2), this can become a hard type mismatch and fail to compile. Align the trait signature and this impl to use the same concrete error type/version (either update axklib/axerrno versions to match, or avoid axklib::AxResult in the interface).