feat(Button, StringSelect): Add options to change custom_id and values#121
Open
qelli wants to merge 1 commit intoStartITBot:masterfrom
Open
feat(Button, StringSelect): Add options to change custom_id and values#121qelli wants to merge 1 commit intoStartITBot:masterfrom
qelli wants to merge 1 commit intoStartITBot:masterfrom
Conversation
qelli
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
Been using your app for a while now so this is some way of saying: thank you!
This PR includes:
custom_idfor Buttonscustom_idfor StringSelectsvaluefor options within a StringSelectChanges in some
key={}attributes were necessary because usingcustom_id&valueas unique forced the component to re-render with the state updates made inonChange()(here) causing the text input to close instead of waiting for the Enter or ESC key press.All the logic behind the Button was preserved as I'm aware of the incompatibility of
custom_id+url.I only speak two languages from the locales list, lmk if you want me to update any of them.
Closes #83