Open
Conversation
mfan127
force-pushed
the
migrate-content-from-radar
branch
from
574b375 to
93e590e
Compare
Contributor
Purple OC Radar reviewOverall
Hero
Appbar
|
jptissot
reviewed
Oct 20, 2021
| </v-col> | ||
| </v-row> | ||
| <v-row> | ||
| {% for activity in Model.ContentItem.Content.Activities.ContentItems %} |
Contributor
There was a problem hiding this comment.
Could we use a query to get the most recent activities.
Collaborator
Author
There was a problem hiding this comment.
The query is here:
jptissot
reviewed
Oct 20, 2021
jptissot
reviewed
Oct 26, 2021
| @@ -0,0 +1,98 @@ | |||
| const attachSorter = function() { | |||
Contributor
There was a problem hiding this comment.
This sorter assumes all data is loaded client side. Might have to switch to a api call in the future.
jptissot
suggested changes
Oct 27, 2021
|
|
||
| namespace StatCan.OrchardCore.Radar.Liquid | ||
| { | ||
| public class CurrentCultureFilter: ILiquidFilter |
Contributor
There was a problem hiding this comment.
Can you move this one to the StatCan.OrchardCore.DisplayHelpers module with a more specific name. Something like filter_current_culture
Collaborator
Author
|
Change now
Things to consider for later
DNS:
|
localize app bar title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates radar to OC.