Skip to content

Self consistency 2 tally consistency report#1

Open
SteSeg wants to merge 10 commits intoself-consistency_1_talliesfrom
self-consistency_2_tally_consistency_report
Open

Self consistency 2 tally consistency report#1
SteSeg wants to merge 10 commits intoself-consistency_1_talliesfrom
self-consistency_2_tally_consistency_report

Conversation

@SteSeg
Copy link
Copy Markdown
Owner

@SteSeg SteSeg commented Apr 15, 2026

this PR adds the internal piping to check whether resulting tallies from a benchmark (here provided with the openmc backend), converted to an ofb Tally, has the shape consistent with what defined in the benchmark specifications file.

In addition, a get_spec_consistency_report() method has been implemented in the BenchmarkResults/Results class. Such report provides informations about the actual consistency of all the tallies resulting from a given benchmark run with the specifications requirements. Example usage:

import openmc_fusion_benchmarks as ofb

# Get results from a benchmark run
br = ofb.BenchmarkResults(`benchmark_results.h5`)

# Get tallies consistency report
report = br.get_spec_consistency_report()
# Get only the tally results-specifications mismatches 
mismatches = br.get_spec_consistency_report(only_mismatches=True)

# Print
print(report)
print(mismatches)

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 16, 2026

Coverage Report for CI Build 24521462984

Coverage increased (+3.1%) to 60.606%

Details

  • Coverage increased (+3.1%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 27 coverage regressions across 3 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

27 previously-covered lines in 3 files lost coverage.

File Lines Losing Coverage Coverage
/usr/share/miniconda3/envs/test-env/lib/python3.13/site-packages/openmc_fusion_benchmarks/benchmark_results.py 12 86.36%
/usr/share/miniconda3/envs/test-env/lib/python3.13/site-packages/openmc_fusion_benchmarks/backends/openmc/tallies.py 9 94.35%
/usr/share/miniconda3/envs/test-env/lib/python3.13/site-packages/openmc_fusion_benchmarks/benchmark.py 6 83.33%

Coverage Stats

Coverage Status
Relevant Lines: 1386
Covered Lines: 840
Line Coverage: 60.61%
Coverage Strength: 0.61 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants