-
Notifications
You must be signed in to change notification settings - Fork 17
feat: add Dota Stats plugin #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
up |
|
We won't be adding any new plugins until Lua support is released. As described in the discord and the plugin template, we are moving from Python backends to Lua. Unfortunately, there is no benefit of accepting a Python plugin right now if it will just have to be ported to Lua right after. |
|
There is a prime time so that I can make new plugins and add this? |
|
I don't understand |
|
Sorry, I don't know English very well. I wanted to ask when there will be a transition to Lua so I can add my Dotastats plugin. |
|
Hi BambooFury - The Lua transition is done from what I can tell. I just released a plugin in Lua a few days ago. After initially writing the backend in python I saw this thread and ported my backend to Lua. It's not too bad. You can use my plugin as a reference in case useful: Also of course the plugin template, which is also in Lua: |
|
I remade the plugin in Lua. |
|
Your PR adds your repo at 1f263cf which isn't a valid commit. |
|
The plugin is missing a webkit. Check the plugin example. |
|
I'll decide everything now |
|
Updated the fork and synced with upstream. Webkit is included now. Please review when you have time. |
|
Your setup is still wrong. Check the plugin template, use that as a reference. |
|
I completely redesigned the plugin structure. If anything is wrong, please describe the problem in detail so we can solve it. |
Add dotastats plugin as a submodule.
Submodule: plugins/dotastats
URL: https://github.com/BambooFury/Dota-Stats.git