Use DuckDB C API in query evaluator

src/cut.cpp

@@ -50,11 +50,16 @@ int main(
         return 1;
     }
 
-    auto &query_plan = overall_query_plan->get_plans().back();
-    query_plan.select.emplace(
-        query_plan.select->get_tablenames(),
+    auto &select = overall_query_plan->get_plans().back();
+    if (!select.select.has_value()) {
+        std::cerr << "No SELECT fragment in final query plan.\n";
+        return 1;
+    }
+
+    select.select.emplace(
+        select.select->get_tablenames(),
         options.get_fields(),
-        query_plan.select->get_alias()
+        select.select->get_alias()
     );
 
     return static_cast<int>(dump_or_eval_query_plan(*overall_query_plan));

src/eval.cpp

@@ -28,8 +28,8 @@ class EvalOptions final : public Options {
 
     bool parse(
         const int argc,
-        const char *argv[]
-    ) override { // NOLINT(*-avoid-c-arrays)
+        const char *argv[] // NOLINT(*-avoid-c-arrays)
+    ) override {
         if (bool const parent_result = Options::parse(argc, argv); !parent_result) {
             return parent_result;
         }
@@ -137,7 +137,7 @@ int main(
         }
         const auto [query_str, query_params] = *query;
         std::cout << query_str << '\n';
-        for (const auto &[column, value] : query_params) {
+        for (const auto &[column, value]: query_params) {
             std::cout << "-- Colum " << column << ": " << value << '\n';
         }
         return static_cast<int>(ExitStatus::SUCCESS);

src/grep.cpp

@@ -28,8 +28,8 @@ class GrepOptions final : public Options {
 
     bool parse(
         const int argc,
-        const char *argv[]
-    ) override { // NOLINT(*-avoid-c-arrays)
+        const char *argv[] // NOLINT(*-avoid-c-arrays)
+    ) override {
         if (bool const parent_result = Options::parse(argc, argv); !parent_result) {
             return parent_result;
         }

src/head.cpp

@@ -23,8 +23,8 @@ class HeadOptions final : public Options {
 
     bool parse(
         const int argc,
-        const char *argv[]
-    ) override { // NOLINT(*-avoid-c-arrays)
+        const char *argv[] // NOLINT(*-avoid-c-arrays)
+    ) override {
         if (bool const parent_result = Options::parse(argc, argv); !parent_result) {
             return parent_result;
         }

src/join.cpp

@@ -1,3 +1,4 @@
+#include <algorithm>
 #include <string>
 
 #include <boost/program_options.hpp>
@@ -61,7 +62,7 @@ class JoinOptions final : public Options {
     void parse_option_switches(
         std::vector<JoinCondition> &conditions
     ) const {
-        const auto num_args = std::min(left_.size(), std::min(right_.size(), predicate_.size()));
+        const auto num_args = std::min({left_.size(), right_.size(), predicate_.size()});
         if (left_.size() != num_args || right_.size() != num_args || predicate_.size() != num_args) {
             std::cerr << "Number of left, right and predicate arguments must be the same. Got " << left_.size() << ", "
                     << right_.size() << " and " << predicate_.size() << ". Using the first " << num_args << "\n";
@@ -84,8 +85,8 @@ class JoinOptions final : public Options {
             conditions.push_back(
                 JoinCondition{
                     .left = positional_args_[i * 3],
-                    .predicate = positional_args_[i * 3 + 1],
-                    .right = positional_args_[i * 3 + 2]
+                    .predicate = positional_args_[(i * 3) + 1],
+                    .right = positional_args_[(i * 3) + 2]
                 }
             );
         }

src/options.h

@@ -38,8 +38,8 @@ class Options {
 
     virtual bool parse(
         const int argc,
-        const char *argv[]
-    ) { // NOLINT(*-avoid-c-arrays)
+        const char *argv[] // NOLINT(*-avoid-c-arrays)
+    ) {
         namespace po = boost::program_options;
 
         try {