feat: improve error messages for failed agent operations#78
Open
JerryIdoko wants to merge 1 commit into
Open
Conversation
This change introduces a centralized error decoder that translates Stellar and Soroban error codes into human-readable messages. It improves the UX by providing clearer feedback when transactions fail due to insufficient funds, missing trustlines, or slippage.
There was a problem hiding this comment.
1 issue found across 6 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="lib/contract.ts">
<violation number="1" location="lib/contract.ts:157">
P2: Rewrapping every failure here discards the original error object, so callers lose the underlying type, stack, and SDK-specific fields.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| throw error; | ||
| const decodedError = decodeStellarError(error); | ||
| console.error(`Error in contract interaction (${functName}):`, decodedError); | ||
| throw new Error(`Contract interaction failed: ${decodedError}`); |
There was a problem hiding this comment.
P2: Rewrapping every failure here discards the original error object, so callers lose the underlying type, stack, and SDK-specific fields.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At lib/contract.ts, line 157:
<comment>Rewrapping every failure here discards the original error object, so callers lose the underlying type, stack, and SDK-specific fields.</comment>
<file context>
@@ -149,9 +152,9 @@ import {
- throw error;
+ const decodedError = decodeStellarError(error);
+ console.error(`Error in contract interaction (${functName}):`, decodedError);
+ throw new Error(`Contract interaction failed: ${decodedError}`);
}
};
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue #3 by introducing a centralized error decoder for Stellar and Soroban operations.
Key Changes:
Why:
Users previously received generic error messages like 'Transaction failed with status: 400'. Now, they will see descriptive messages such as 'Account has insufficient funds for this operation' or 'Missing trustline for asset', significantly improving the developer experience.
Resolves #3