Skip to content

Enhancement: emit admin config update events#56

Merged
Jayrodri088 merged 1 commit intoStellarState:mainfrom
Josue19-08:feat/issue-13-admin-config-events
Mar 27, 2026
Merged

Enhancement: emit admin config update events#56
Jayrodri088 merged 1 commit intoStellarState:mainfrom
Josue19-08:feat/issue-13-admin-config-events

Conversation

@Josue19-08
Copy link
Copy Markdown
Contributor

Description

Emit explicit events for admin/config updates in invoice-token and invoice-escrow, and document the new event surfaces in docs/API.md.

Closes #13

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 Documentation update
  • 🎨 UI/UX improvement
  • ♻️ Code refactoring
  • ✅ Test addition or update
  • 🔧 Configuration change

Checklist

  • My code follows the code style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Testing

How to Test

  1. Run cargo test -p invoice-token.
  2. Run cargo test -p invoice-escrow.
  3. Run cargo test --workspace.
  4. Run cargo clippy --workspace --all-targets -- -D warnings.

Test Coverage

  • Unit tests added/updated
  • Integration tests added/updated
  • E2E tests added/updated (if applicable)
  • Manual testing completed

Additional Notes

This PR adds event emission for set_transfer_locked, set_minter, and update_platform_fee_bps.

@drips-wave
Copy link
Copy Markdown

drips-wave bot commented Mar 26, 2026

@Josue19-08 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Jayrodri088 Jayrodri088 merged commit 432a9f8 into StellarState:main Mar 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Emit events for admin config updates (escrow + token)

2 participants