Two bugs: size_t >=0 and empty array/objects#5
Open
jpoag wants to merge 2 commits intoSteve132:masterfrom
jpoag:master
Open
Two bugs: size_t >=0 and empty array/objects#5jpoag wants to merge 2 commits intoSteve132:masterfrom jpoag:master
jpoag wants to merge 2 commits intoSteve132:masterfrom
jpoag:master
Conversation
* size of array or object can be zero, need to determine if size is read
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs found:
Notes on # 2:
I was testing the compatibility between this library and another converter and the converter wrote an empty array as:
'[' '#' 'i' '0'Unfortunately, this ubjson parser was using the zero size to determine whether or not to read the closing array marker ']'. This caused a stack overflow on some files and infinite recursion on others...
I have suggested to the other library to write empty arrays as
'[' ']', however, it is not technically wrong to have a zero sized container, as per spec: