Skip to content

Read and write JSONLab/JData flavored optimized N-D array header#8

Open
fangq wants to merge 6 commits intoSteve132:masterfrom
fangq:master
Open

Read and write JSONLab/JData flavored optimized N-D array header#8
fangq wants to merge 6 commits intoSteve132:masterfrom
fangq:master

Conversation

@fangq
Copy link

@fangq fangq commented May 15, 2019

see ubjson/universal-binary-json#61 (comment)

Fixed a few gcc warnings, added the missing ubjw_begin_ndarray() function.

valgrind now gives me a lost buffer inside priv_ubjr_read_raw_array() which I modified, I suspect it is related to this line, not sure if that call releases the memory associated with the temp variable.

@Steve132
Copy link
Owner

Why does your spec differ from the existing ND array functionality extension inside UBJ (using the @ character) It looks to provide the same functionality exactly, with the same ordering.

@fangq
Copy link
Author

fangq commented May 13, 2020

I guess it was probably because it was implemented in my JSONLab toolbox about 1 year before your proposal of the @ format, which I only noticed it many years later. At that point, there is already a sizable user community for jsonlab, and I don't want it to break backward compatibility. I agree these ideas are rather similar.

@fangq
Copy link
Author

fangq commented May 13, 2020

maybe I overlooked, I did not see the #+@ syntax in the Draft 12 of the spec, was it accepted?

@Steve132
Copy link
Owner

Steve132 commented May 13, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants