Open
Conversation
added seaborn to requirements fix reset in interactive_phaseogram
matteobachetti
requested changes
Jun 25, 2025
Member
matteobachetti
left a comment
matteobachetti
left a comment
There was a problem hiding this comment.
@Apicazo9 thanks for your PR!
At lines 108-110 you say that the issue expects arrays, but you haven't changed the code?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seaborn library was missing in requirements.
stingray\docs\notebooks\Pulsar\Pulsar search with epoch folding and Z squared.ipynb: Interactive_phaseogram reset wasn't working, because set_xdata function expected an array as an argument. Still missing some set_xdata to fix