Handle ShaguTweaks readiness consistently#26
Open
Hippoom wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
ShaguTweaks can load before or after Reforged depending on addon load order and client setup. Previously, different Reforged modules checked for ShaguTweaks readiness in different ways. Some modules could miss the
ADDON_LOADEDevent if ShaguTweaks had already loaded, while the GUI could build beforeShaguTweaks_configwas available.This PR adds a shared readiness helper with two levels:
ShaguTweaks,ShaguTweaks.T, andShaguTweaks.modsare availableShaguTweaks_configis availableThe cast icon and Shagu GUI now use this shared readiness path instead of local timing logic.
Test plan
Fixes #15