Add optional ShaguTweaks target health values#27
Open
Hippoom wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UnitHealth/UnitHealthMaxbehavior as the default.libhealthdata without re-enabling ShaguTweaks' conflicting health-number rendering module.Details
Reforged disables ShaguTweaks'
Real Health Numbersmodule because that module draws text onto the default Blizzard unit frames, which conflicts with Reforged's custom unit frames.However, Reforged's target frame currently uses the native Vanilla API:
On Vanilla-like clients, these APIs can return percentage-style values such as
100/100for hostile targets, even when ShaguTweaks has cached or estimated real mob health values throughShaguTweaks.libhealth.This PR adds an opt-in Target frame text option:
When enabled, Reforged's target frame uses
ShaguTweaks.libhealth:GetUnitHealth("target")if available, and otherwise falls back to nativeUnitHealth/UnitHealthMax.Test plan
100/100.Fixes #17