Add pet bar layout improvements, profile save action, French localization, and a standalone InstanceJournal micro-menu button#9
Open
rudaznoe wants to merge 5 commits into
Open
Conversation
rudaznoe
changed the title
Author
|
I tried to keep the changes as modular and non-intrusive as possible. The InstanceJournal button is implemented as a standalone DFUI-styled button instead of modifying the internal micro-menu button list, because this approach proved much more stable in practice. |
- Added standalone InstanceJournal button (non-intrusive) - Fixed micro menu stability issues - Restored correct icon behavior (PvP, EBC) - Removed redundant Reload Profile button - Improved overall UI consistency
fix(ui): correct PvP micro menu icon The PvP button was using a fallback icon (Instance Journal), causing visual inconsistency in the micro menu. This change assigns a proper PvP icon while keeping the original button styling and behavior intact (no texture override).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds several quality-of-life improvements to DragonflightUI-Reforged while keeping the existing behavior as stable as possible.
Included changes
Added improved pet bar layout support
Added a manual Save Profile action in the Profiles panel
Extended French localization
Added a standalone InstanceJournal micro-menu button
Removed the redundant Reload Profile button
Technical notes
Pet bar
The pet bar layout logic was extended to support more flexible positioning without intentionally breaking the existing action bar system.
Profiles
The Profiles panel now exposes an explicit save action, while keeping live configuration updates unchanged.
Localization
French translations were expanded and kept backward-compatible through English fallback behavior.
InstanceJournal integration
Instead of injecting an external button into the internal micro-menu flow, this PR adds a separate DragonflightUI-owned button anchored to the micro-menu container.
This approach was chosen to avoid regressions in the original micro-menu behavior.
Compatibility
Tested
Tested in Turtle WoW for: