feat(backend): POST /api/v1/streams — create stream endpoint with Zod validation#79
Merged
greatest0fallt1me merged 2 commits intoStreampay-Org:mainfrom Apr 1, 2026
Conversation
… validation Implements the create stream API for issue Streampay-Org#3. Changes: - Add to StreamRepository using Drizzle insert().values().returning() consistent with existing query patterns - Add Zod schema validating: - payer / recipient (non-empty strings) - ratePerSecond / totalAmount (positive decimal strings) - startTime / endTime (ISO-8601 datetime; endTime optional) - Add POST /api/v1/streams handler: validate body → persist → return 201 + stream - Stream status defaults to active; lastSettledAt seeded from startTime - Return structured 400 validation errors with per-field details via zod.flatten().fieldErrors Tests (supertest): - 201 success path with mocked repository - 400 missing required fields - 400 invalid ratePerSecond (non-decimal string) - 400 invalid startTime (non-ISO-8601) - 500 when repository throws unexpectedly Security notes: - All input sanitised through Zod before reaching the repository - No raw user input passed to DB queries - Decimal fields accepted as strings to avoid float precision issues Draft — optional chain invoke not yet wired (follow-up issue)
|
@Oluwaseyi89 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: POST /api/v1/streams — Create Stream Endpoint
Implements create stream API as specified in #3.
Changes
Files
modified: src/api/v1/streams.ts
modified: src/api/v1/streams.test.ts
modified: src/repositories/streamRepository.ts
Validation Rules
Test Coverage
Security
Closes #3