Commands now give useful error messages even without consoleTrace active#50
Open
klianc09 wants to merge 1 commit into
Open
Commands now give useful error messages even without consoleTrace active#50klianc09 wants to merge 1 commit into
klianc09 wants to merge 1 commit into
Conversation
| log(e, LogLevel.ERROR); | ||
| } else if (e.getCause() instanceof InvocationTargetException) { | ||
| Throwable originalException = e.getCause().getCause(); | ||
| if (originalException != null) { |
There was a problem hiding this comment.
What if originalException is null? What should be the appropriate action? Simply ignore?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
consoleTraceis set to false, exceptions in commands will lead to useless messages:Exception occurred in method: failFunctionThis is caused by the fact that
com.badlogic.gdx.utils.reflect.invoke()wraps theTargetInvokationExceptionwith aReflectionExceptionwith that predefined message, therefore the check for an empty message inAbstractConsoleis never true in that case.With this change the example
failFunctioncommand inBox2DTestwill print the much more helpful:Only tested on desktop. If it causes issues with GWT, the import might need to be avoided, but so far untested.