Refactor: Relocate fspin_cheatsheet.md under fspin directory and …#44
Merged
Refactor: Relocate fspin_cheatsheet.md under fspin directory and …#44
fspin_cheatsheet.md under fspin directory and …#44Conversation
…update manifest accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates how the
fspin_cheatsheet.mdfile is bundled and accessed within thefspinpackage to improve compatibility and reliability across different Python versions and installation methods. The main focus is on usingimportlib.resourcesfor cheatsheet access and ensuring the cheatsheet is correctly included in package distributions.Packaging and resource access improvements:
MANIFEST.into includefspin_cheatsheet.mdfrom within thefspindirectory, ensuring the cheatsheet is packaged correctly.include_package_data=Trueinsetup.pyto make sure package data files like the cheatsheet are included during installation.Cheatsheet loading logic enhancements:
fspin/__main__.pyto useimportlib.resourcesfor readingfspin_cheatsheet.md, providing compatibility with both modern and older Python versions, and added a fallback to load the file from the local filesystem if necessary.…update manifest accordingly.