Skip to content

fix: fix defaultInstrumentation never being registered bug #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shubham-sumo merged 2 commits into from
Feb 4, 2026
Merged

fix: fix defaultInstrumentation never being registered bug #59

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db63deb
fix: fix defaultInstrumentation never being registered bug
shubham-sumo Feb 1, 2026
d29f41c
Merge branch 'main' into default-Instrumentation
shubham-sumo Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions nodejs/packages/layer/src/wrapper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,16 +213,23 @@ if (logLevel === DiagLogLevel.DEBUG) {
);
}

// Get user-configured instrumentations (if any)
const userInstrumentations = typeof global.configureInstrumentations === "function"
? global.configureInstrumentations()
: [];

// Always include default instrumentations (HttpInstrumentation, etc.)
const defaultInstruments = defaultConfigureInstrumentations();

const instrumentations = [
new AwsInstrumentation({
suppressInternalInstrumentation: suppressInternalInstrumentation,
}),
new AwsLambdaInstrumentation({
disableAwsContextPropagation: disableAwsContextPropagation,
}),
...(typeof configureInstrumentations === "function"
? configureInstrumentations
: defaultConfigureInstrumentations)(),
...defaultInstruments,
...userInstrumentations,
];

// Register instrumentations synchronously to ensure code is patched even before provider is ready.
Expand Down
Loading