Restrict shapely dependency to <=2#130
Conversation
|
Hi @campanelli-sunpower, just a bump, especially about cutting a new release that doesn't forbid the latest pvlib :) |
campanelli-sunpower
left a comment
There was a problem hiding this comment.
Because pvfactors is a library, I think we should allow upgrading of Shapely until (but not including) v2, at which point the warnings will become failures.
campanelli-sunpower
left a comment
There was a problem hiding this comment.
Thanks @kanderso-nrel .
|
I suspect the test failures are caused by the numpy change discussed in pvlib/pvlib-python#1369 If that's true (need to verify it locally), I'd advocate for the same fix: weaken the test tolerance a bit to allow for the variation from numpy |
|
@kanderso-nrel Looks like some small numerical drift on the newer Pythons. I think it would be ok to widen the tolerance slightly. Note the recommendation here to not use
|
|
@campanelli-sunpower Shall I update this PR with those changes? |
|
@kanderso-nrel Please do so if you are ok with that. It would keep the review sequence more straightforward. Thanks. |
campanelli-sunpower
left a comment
There was a problem hiding this comment.
Thanks for updating these test methods too.
Closes #126.
I wonder if we should think about releasing 1.5.2 soon? Besides these deprecation warnings and the
tilt=0issue from #125, it would be nice for the latest pvfactors version to allow pvlib==0.9.0 on installation. Someone asked about this on the pvlib google group: https://groups.google.com/g/pvlib-python/c/hNaNsM1pNSw