This repository was archived by the owner on Jun 25, 2025. It is now read-only.
Update keycloak node port, config data and repository name env variable#1
Merged
adrianafdez merged 2 commits intoSunriseOpenOperatorPlatform:mainfrom Jun 3, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Keycloak port and realm configuration, inlines and renames federation-manager configuration, and makes the Docker image tag dynamic by using a lowercase repository environment variable.
- Update test Keycloak realm path
- Change Keycloak NodePort and inline federation-manager config
- Introduce lowercase
REPO_NAMEenv var for dynamic image tags in CI
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/test/init.py | Adjust Keycloak token URL to use the updated realm name |
| src/deploy/keycloak.yaml | Change Keycloak service NodePort from 30080 to 30081 |
| src/deploy/federation-manager.yaml | Inline config.cfg, fix resource names for Deployment and Service |
| .github/workflows/federation-manager.yml | Add lowercase repo name step and update Docker build/push tags |
Comments suppressed due to low confidence (3)
src/deploy/federation-manager.yaml:15
- The block scalar content under
config.cfgis not indented further than the key, which will break YAML parsing; indent all subsequent lines by at least two additional spaces.
config.cfg: >-
src/deploy/federation-manager.yaml:24
- [nitpick] Both the Deployment and Service now share the exact same name; consider adding clear suffixes (e.g.,
-appand-svc) to avoid confusion.
name: federation-manager
.github/workflows/federation-manager.yml:31
- The Bash parameter expansion
${GITHUB_REPOSITORY@L}is not supported in the GitHub Actions runner; use${GITHUB_REPOSITORY,,}to lowercase the repository name.
echo "REPO_NAME=${GITHUB_REPOSITORY@L}" >> ${GITHUB_ENV}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the keycloak node port and config data, as well as sets the repository name as an env variable for building the image.