Open
Conversation
![beta-devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/2443040?s=60&v=4){kind=small}
| with: | ||
| python-version: "3.12" | ||
| - run: pip install pytest | ||
| - run: python -m pytest tests/ -v --tb=short 2>&1 || true |
There was a problem hiding this comment.
🔴 || true causes CI to always pass, even when tests fail
The pytest step uses || true which forces the exit code to 0 regardless of test results. This means the CI job will always report success even when tests fail (or when tests/ doesn't exist — which is currently the case). This completely defeats the purpose of CI as a quality gate, since failing tests will never block a merge.
Suggested change
| - run: python -m pytest tests/ -v --tb=short 2>&1 || true | |
| - run: python -m pytest tests/ -v --tb=short |
Was this helpful? React with 👍 or 👎 to provide feedback.
Debug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds CI workflow for automated testing on push and PR.