Conversation
jonghbae
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Python naming convention issue in Model entity
Changes
trainingAnnotationsattribute totraining_annotationsto follow Python naming convention (snake_case)trainingAnnotationsfor API compatibilityTechnical Details
Modified Files:
spb_onprem/models/entities.pyIssue:
The attribute name
trainingAnnotationsused camelCase instead of Python's snake_case convention, which is inconsistent with other attributes in the Model class.Backward Compatibility
This change maintains backward compatibility through the Field alias. The GraphQL API continues to use
trainingAnnotationswhile Python code uses the conventionaltraining_annotations.Testing