Skip to content

fix: Change trainingAnnotations to training_annotations for Python naming convention#76

Merged
Min-june merged 1 commit intomainfrom
hotfix/fix-the-model-attribute-name-error
Feb 6, 2026
Merged

fix: Change trainingAnnotations to training_annotations for Python naming convention#76
Min-june merged 1 commit intomainfrom
hotfix/fix-the-model-attribute-name-error

Conversation

@Min-june
Copy link
Copy Markdown
Contributor

@Min-june Min-june commented Feb 6, 2026

Summary

Fix Python naming convention issue in Model entity

Changes

  • Changed trainingAnnotations attribute to training_annotations to follow Python naming convention (snake_case)
  • The GraphQL alias remains as trainingAnnotations for API compatibility

Technical Details

Modified Files:

  • spb_onprem/models/entities.py

Issue:
The attribute name trainingAnnotations used camelCase instead of Python's snake_case convention, which is inconsistent with other attributes in the Model class.

Backward Compatibility

This change maintains backward compatibility through the Field alias. The GraphQL API continues to use trainingAnnotations while Python code uses the conventional training_annotations.

Testing

  • Manual testing required
  • Existing tests should pass

@Min-june Min-june merged commit a72c7f2 into main Feb 6, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants