Skip to content

chore: update GitHub Actions to latest versions, add commit linting, and configure native GitHub changelog generation #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SuperCoolPencil wants to merge 2 commits into from
Closed

chore: update GitHub Actions to latest versions, add commit linting, and configure native GitHub changelog generation #413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22c275c
chore: update GitHub Actions to latest versions, add commit linting, …
SuperCoolPencil Apr 24, 2026
262e55c
Potential fix for pull request finding 'CodeQL / Workflow does not co…
SuperCoolPencil Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
changelog:
exclude:
labels:
- skip-changelog
authors:
- dependabot[bot]
categories:
- title: "Features"
labels:
- feat
- enhancement
- title: "Bug Fixes"
labels:
- fix
- bug
- title: "Internal Changes"
labels:
- "*"
8 changes: 4 additions & 4 deletions .github/workflows/build-push-images.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@v6

- name: Get Surge version
id: surge-version
Expand Down Expand Up @@ -72,23 +72,23 @@ jobs:
uses: docker/setup-buildx-action@v3

- name: Log in to Container Registry
uses: docker/login-action@v3
uses: docker/login-action@v4
with:
registry: ${{ env.REGISTRY }}
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Extract metadata (tags, labels)
id: meta
uses: docker/metadata-action@v5
uses: docker/metadata-action@v6
with:
images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}
tags: |
type=raw,value=${{ steps.surge-version.outputs.version }}
type=raw,value=latest,enable=${{ steps.latest-tag.outputs.enable }}

- name: Build and push Docker image
uses: docker/build-push-action@v5
uses: docker/build-push-action@v7
with:
context: docker
file: docker/Dockerfile
Expand Down
27 changes: 27 additions & 0 deletions .github/workflows/commit-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: "Conventional Commits"

on:
push:
branches:
- main
pull_request:
types:
- opened
- edited
- reopened
- synchronize

permissions:
contents: read

jobs:
lint:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v6
with:
fetch-depth: 0

- name: Check commits
uses: webiny/action-conventional-commits@v1.3.1
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
6 changes: 3 additions & 3 deletions .github/workflows/core-binary-size-compare.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,12 @@ jobs:
name: Compare Binary Size
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
with:
fetch-depth: 0

- name: Set up Go
uses: actions/setup-go@v5
uses: actions/setup-go@v6
with:
go-version: "1.25.0"
check-latest: false
Expand Down Expand Up @@ -61,7 +61,7 @@ jobs:
echo "${{ github.event.pull_request.number }}" > pr_number.txt

- name: Upload artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
with:
name: binary-size-data
path: |
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/core-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ jobs:
os: [ubuntu-latest, macos-latest, windows-latest]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- name: Set up Go
uses: actions/setup-go@v5
uses: actions/setup-go@v6
with:
go-version: "1.25.0"
check-latest: false
Expand All @@ -49,7 +49,7 @@ jobs:
fi
gotestsum --junitfile test-results.xml --format testdox $cover_arg ./...
- name: Upload Test Results
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
if: always()
with:
name: test-results-${{ matrix.os }}
Expand All @@ -69,15 +69,15 @@ jobs:
if: startsWith(github.ref, 'refs/tags/v') && !startsWith(github.ref, 'refs/tags/ext-v')
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v6
with:
fetch-depth: 0
- name: Set up Go
uses: actions/setup-go@v5
uses: actions/setup-go@v6
with:
go-version: "1.25.0"
- name: Run GoReleaser
uses: goreleaser/goreleaser-action@v6
uses: goreleaser/goreleaser-action@v7
with:
distribution: goreleaser-pro
version: latest
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/core-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ jobs:
name: lint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
- uses: actions/checkout@v6
- uses: actions/setup-go@v6
with:
go-version: '1.25.0'
- name: golangci-lint
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/extension-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ jobs:
run:
working-directory: extension
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- name: Set up Node.js
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version: "22"
cache: "npm"
Expand All @@ -32,9 +32,9 @@ jobs:
run:
working-directory: extension
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- name: Set up Node.js
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version: "22"
cache: "npm"
Expand All @@ -50,9 +50,9 @@ jobs:
run:
working-directory: extension
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- name: Set up Node.js
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version: "22"
cache: "npm"
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/extension.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ jobs:
run:
working-directory: extension
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- name: Set up Node.js
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version: "22"
cache: "npm"
Expand All @@ -54,7 +54,7 @@ jobs:
run: |
npm run zip -- -b ${{ matrix.browser }}
- name: Upload Artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
with:
name: extension-${{ matrix.browser }}
path: extension/output/*.zip
Expand All @@ -76,15 +76,15 @@ jobs:
if: startsWith(github.ref, 'refs/tags/ext-v')
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- name: Download all artifacts
uses: actions/download-artifact@v4
uses: actions/download-artifact@v8
Comment on lines 57 to +81
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 upload-artifact/download-artifact major-version mismatch

The build job uploads with actions/upload-artifact@v7 while the release job downloads with actions/download-artifact@v8. These two actions use a shared internal artifact format, and different major versions are not guaranteed to be cross-compatible — a v7-produced artifact may not be correctly read by the v8 client, causing the release job to fail silently or error out on ext-v* tag pushes.

Both actions should be pinned to the same major version. Either downgrade the download to @v7 or upgrade the upload to @v8.

Suggested change
uses: actions/upload-artifact@v8
Prompt To Fix With AI 
This is a comment left during a code review.
Path: .github/workflows/extension.yml
Line: 57-81

Comment:
**upload-artifact/download-artifact major-version mismatch**

The `build` job uploads with `actions/upload-artifact@v7` while the `release` job downloads with `actions/download-artifact@v8`. These two actions use a shared internal artifact format, and different major versions are not guaranteed to be cross-compatible — a v7-produced artifact may not be correctly read by the v8 client, causing the release job to fail silently or error out on `ext-v*` tag pushes.

Both actions should be pinned to the same major version. Either downgrade the download to `@v7` or upgrade the upload to `@v8`.

```suggestion
        uses: actions/upload-artifact@v8
```

How can I resolve this? If you propose a fix, please make it concise.

with:
path: artifacts
pattern: extension-*
merge-multiple: true
- name: Create Release
uses: softprops/action-gh-release@v2
uses: softprops/action-gh-release@v3
with:
files: artifacts/*.zip
generate_release_notes: true
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@ jobs:
name: Extension ↔ Surge Backend
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6

- name: Set up Go
uses: actions/setup-go@v5
uses: actions/setup-go@v6
with:
go-version: "1.25.0"
check-latest: false
Expand All @@ -45,7 +45,7 @@ jobs:
run: go build -o surge .

- name: Set up Node.js
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version: "22"
cache: "npm"
Expand Down
8 changes: 2 additions & 6 deletions .goreleaser.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ before:
- ./scripts/package-themes.sh

release:
header: "## Changelog"
footer: |
---
**Enjoying Surge?** Consider supporting the project to keep it blazing fast!
Expand All @@ -32,12 +33,7 @@ release:
- glob: .goreleaser-extra/themes.zip

changelog:
sort: asc

filters:
exclude:
- "^docs:"
- "^test:"
use: github-native

archives:
- formats: [ tar.gz ]
Expand Down
Loading