feat: implement soft delete and archived status for deliveries#72
Open
jerryjuche wants to merge 1 commit into
Open
feat: implement soft delete and archived status for deliveries#72jerryjuche wants to merge 1 commit into
jerryjuche wants to merge 1 commit into
Conversation
|
@jerryjuche Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21
Summary
Implements soft-delete logic and archived status for Deliveries (Closes #21).
What changed
src/models/Delivery.ts): AddedisDeleted,deletedAt,deletedByfields to schema. Pre-find/countDocumentsmiddleware auto-filters soft-deleted docs (bypassable via.setOptions({ includeDeleted: true })). Instance methodssoftDelete()andrestore().src/services/delivery.service.ts): Full CRUD plusarchive(),restore(),listArchived()— all queries respect the soft-delete filter naturally.src/controllers/delivery.controller.ts): Thin handlers wrapping the service with proper HTTP status codes and error forwarding.src/routes/delivery.routes.ts):POST /,GET /,GET /:id,PATCH /:id,PATCH /:id/archive,PATCH /:id/restore,GET /archived.AppErrorclass insrc/utils/AppError.tsreplaces inlineas anycasts.dotenv.config()toserver.ts(was missing).Acceptance criteria checklist
isDeletedflag on Delivery schemaPATCH /:id/archive)/api/v1/AppError+ global error handlertsc --noEmitpasses cleaneslint . --ext .tspasses with 0 errors, 0 warningsTest results
Follow-ups
archiveendpoint accepts an optionaluserIdbut there's no auth guard yet — auth was out of scope for this issue)Security note
The
userIdin the archive endpoint is extracted fromreq.user(set by auth middleware) but gracefully handlesundefinedif no auth middleware is in place yet.