Qr code scanner permissions error boundary#221
Merged
johdanike merged 2 commits intoJul 1, 2026
Merged
Conversation
|
@GiftedGiftB Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #155
This PR introduces robust error handling and interaction tests for the Driver QR Code Scanner, specifically targeting the scenario where a user denies camera permissions. The implementation strictly follows the Component -> Hook -> Service layered architecture, ensuring separation of concerns and maintainability.
📋 Summary of Work Done
QrScanner.tsx): Built the QR scanner UI with an explicit error boundary fallback that clearly directs drivers to their browser settings if camera permissions are denied.useQrScanner.ts): Implemented the camera stream initialization logic, properly catchingNotAllowedErrorandPermissionDeniedErrorexceptions to surface meaningful error states.qrScannerService.ts): Created a mock API service layer for verifying QR data, adhering to the requirement for externalized response data.QrScanner.test.tsx): Wrote rigorous unit tests utilizing Jest and React Testing Library to mocknavigator.mediaDevices.getUserMedia. Verified that the fallback UI correctly renders upon a rejected promise.qrScannerMockData.ts): Extracted mock responses to prevent the use of inline mock objects within the test assertions.✅ Acceptance Criteria Met
📸 Screenshots
(Please drag and drop the screenshot of your terminal showing the passing
pnpm testexecution here before submitting)🧪 How to Test
git checkout QRCodeScannerPermissionsErrorBoundarypnpm test -- __tests__/components/logistics/QrScanner.test.tsx