feat: Store tokens from authentication in system keystore#71
Merged
Conversation
eikek
force-pushed
the
feat/token-keystore
branch
2 times, most recently
from
70ca47d to
9e825b9
Compare
eikek
force-pushed
the
feat/token-keystore
branch
from
9e825b9 to
7f69b4b
Compare
eikek
force-pushed
the
feat/token-keystore
branch
from
092e9e9 to
44cb87a
Compare
Panaetius
requested changes
Jun 19, 2026
Panaetius
left a comment
Panaetius
left a comment
Member
There was a problem hiding this comment.
Looks good, very nice work with making the keystore configurable.
Comment on lines
+201
to
+202
| #keyutils | ||
| #gnome-keyring |
Member
There was a problem hiding this comment.
Is this leftover code? I assume this means commented out?
Member
Author
There was a problem hiding this comment.
Yes it is commented out, to be easily activated if someone wants to test things wrt keystore. I can also remove it, but it is only part of the development shell.
Panaetius
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the way the auth tokens are stored, using the
keyring-rscrate. It provides integration into the system keyring for Linux, Windows and OSX. For Linux, the DBus variant is preferred if it is available, otherwise the kernel keyring is used. It is possible to force a specific variant via an env variable, which is meant as a fallback if the default behavior doesn't work for some reason.Then the project context is also being read from the
.renku/config.tomlfile if present. It would be preferred to an environment variable. The file is created, if a project is cloned with this tool.