fix(backend): handle instance -> standalone conversion #1436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vents - Implemented `instanceToStandalone` method in `GcalEventParser` to convert recurrence instances into standalone events, enhancing event management capabilities. - Updated `GcalSyncProcessor` to handle the new conversion case in the event processing logic. - Added unit tests to validate the functionality of detaching instances into standalone events, ensuring correct behavior and data integrity during synchronization. This change improves the flexibility of the Google Calendar synchronization process, allowing users to manage their events more effectively.
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on March 3. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a sync logic error when converting a recurrence instance to a standalone event in Google Calendar synchronization. Previously, when a user edited a single instance in Google Calendar to detach it from a recurring series, the sync processor would throw an unhandled transition error.
Changes:
- Added a new case handler
RECURRENCE_INSTANCE->>STANDALONE_CONFIRMEDin the GcalSyncProcessor switch statement - Implemented
instanceToStandalonemethod in GcalEventParser that removes recurrence properties and updates the event as standalone - Added comprehensive unit test validating the detachment functionality and data integrity
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/backend/src/sync/services/sync/gcal.sync.processor.ts | Added switch case to handle RECURRENCE_INSTANCE->>STANDALONE_CONFIRMED transition by calling the new instanceToStandalone method |
| packages/backend/src/event/classes/gcal.event.parser.ts | Implemented instanceToStandalone method to convert instance events to standalone by removing recurrence and gRecurringEventId properties |
| packages/backend/src/sync/services/sync/tests/gcal.sync.processor.upsert.instance.test.ts | Added test case verifying correct handling of instance detachment, including proper removal of recurrence properties and correct transition/operation reporting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1434
instanceToStandalonemethod inGcalEventParserto convert recurrence instances into standalone events, enhancing event management capabilities.GcalSyncProcessorto handle the new conversion case in the event processing logic.This change improves the flexibility of the Google Calendar synchronization process, allowing users to manage their events more effectively.