๐ fix: WorkspaceMember ํํด ๋ฐ ์ถ๋ฐฉ ์ ChatMessage์ ์ธ๋ ํค ์ ์ฝ ์กฐ๊ฑด์ผ๋ก ์ธํ ์ญ์ ์คํจ ๋ฌธโฆ#119
Conversation
โฆ์ ๋ฅผ ํด๊ฒฐ Changes: - ChatMessage.sender๋ฅผ nullable๋ก ๋ณ๊ฒฝํ์ฌ ํํดํ ์ฌ์ฉ์์ ๋ฉ์์ง ์ ์ง - ChatMessageRepository์ nullifySenderByWorkspaceMemberId() ์ถ๊ฐ - leaveWorkspace()์ kickMember()์์ ๋ฉค๋ฒ ์ญ์ ์ sender null ์ฒ๋ฆฌ - ChatConverter์์ null sender๋ฅผ "ํํดํ ์ฌ์ฉ์"๋ก ํ์
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
โ๏ธIssue Number
close # 118
๐ ๊ฐ์
๐ fix: WorkspaceMember ํํด/์ถ๋ฐฉ ์ ์ธ๋ ํค ์ ์ฝ ์กฐ๊ฑด ์ค๋ฅ ์์
์ํฌ์คํ์ด์ค ๋ฉค๋ฒ๊ฐ ํํดํ๊ฑฐ๋ ์ถ๋ฐฉ๋ ๋, ChatMessage ์ํฐํฐ์์ ์ธ๋ ํค ์ ์ฝ ์กฐ๊ฑด์ผ๋ก ์ธํด ์ญ์ ๊ฐ ์คํจํ๋ ๋ฒ๊ทธ ์์
๐ ๋ณ๊ฒฝ ์ฌํญ
sender ํ๋๋ฅผ nullable = true๋ก ๋ณ๊ฒฝ
๋ฉค๋ฒ ์ญ์ ์ ์ ํด๋น ๋ฉค๋ฒ๊ฐ ๋ณด๋ธ ๋ชจ๋ ๋ฉ์์ง์ sender๋ฅผ null๋ก ์ค์
ํด๋ผ์ด์ธํธ์์๋ "ํํดํ ์ฌ์ฉ์"๋ก ํ์
๐ธ ์คํฌ๋ฆฐ์ท
๐ ๊ธฐํ ๋ ์ด์ผ๊ธฐํด๋ณผ ์