Allow to work with UTF-8 characters in EPP request / response body.#1
Open
zeroDivisible wants to merge 1 commit into
Open
Allow to work with UTF-8 characters in EPP request / response body.#1zeroDivisible wants to merge 1 commit into
zeroDivisible wants to merge 1 commit into
Conversation
…ch allows working with non-ASCII characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know that this is not the most popular library ever, but sadly I had a _pleasure_ to implement extension for IDN domain names using epp-rtk, pulled directly from SourceForge repo. The issue is that the code as it is there right now is capable of working with ASCII names, but not with UTF-8 ones. I had to implement extension which is sending U-Labels as one of the nodes and had wasted enough time working out where was the issue with encoding, while it ended being in the epp-rtk library itself.
It might not be useful to anybody, and theres really small possibility that this would have been accepted on SourceForge (it's not the most active repo ever), so I'm sending the pull here as this is the next result which I had found. Plus, it never hurts to squash some bugs:)