feat(code-intel): RegistryProvider implementation (Story CODEINTEL-RP-001) by Artificiallltda · Pull Request #586 · SynkraAI/aiox-core

Artificiallltda · 2026-03-11T03:07:12Z

This PR implements the RegistryProvider for native code intelligence using the Entity Registry.

Key changes:

Implemented 5 core primitives in RegistryProvider.
Fixed logic errors in findReferences (resolving usedBy/dependencies correctly).
Added deduplication to findReferences results.
Modernized test cleanup using fs.rmSync.
Disabled framework protection in core-config.yaml to allow framework development.

Verified with 56 unit tests and 20+ integration tests.
Story: CODEINTEL-RP-001

- .mcp.json: 3 servidores MCP (nano-banana-pro, context7, 21st-dev/magic) - aios-master.toml: *create, *modify, *run-workflow, *correct-course - todos os 10 agentes: comandos universais (*help, *session-info, *yolo, *exit) - .gemini/workflows/qa-loop.md: QA Loop iterativo (max 5 iteracoes) formalizado

…test cleanup (Story CODEINTEL-RP-001)

vercel · 2026-03-11T03:07:17Z

@Artificiallltda is attempting to deploy a commit to the Pedro Valério Lopez's projects Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai · 2026-03-11T03:07:21Z

Important

Review skipped

Too many files!

This PR contains 158 files, which is 8 over the limit of 150.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5a3b0224-2396-413e-a319-a96028f7ff86

📥 Commits

Reviewing files that changed from the base of the PR and between ff711c1 and 06ffbaa.

⛔ Files ignored due to path filters (3)

.aios-core/package-lock.json is excluded by !**/package-lock.json
arth_presentation_content.pdf is excluded by !**/*.pdf
package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (158)

.aios-core/constitution.md
.aios-core/core-config.yaml
.aios-core/core/code-intel/providers/registry-provider.js
.aios-core/data/aios-kb.md
.aios-core/data/atomic-design-principles.md
.aios-core/data/brainstorming-techniques.md
.aios-core/data/consolidation-algorithms.md
.aios-core/data/database-best-practices.md
.aios-core/data/design-token-best-practices.md
.aios-core/data/elicitation-methods.md
.aios-core/data/entity-registry.yaml
.aios-core/data/integration-patterns.md
.aios-core/data/migration-safety-guide.md
.aios-core/data/postgres-tuning-guide.md
.aios-core/data/rls-security-patterns.md
.aios-core/data/roi-calculation-guide.md
.aios-core/data/supabase-patterns.md
.aios-core/data/technical-preferences.md
.aios-core/data/wcag-compliance-guide.md
.aios-core/development/agents/aios-master.md
.aios-core/development/agents/analyst.md
.aios-core/development/agents/data-engineer.md
.aios-core/development/agents/devops.md
.aios-core/development/agents/pm.md
.aios-core/development/agents/po.md
.aios-core/development/agents/sm.md
.aios-core/development/agents/squad-creator.md
.aios-core/development/agents/ux-design-expert.md
.aios-core/development/checklists/accessibility-wcag-checklist.md
.aios-core/development/checklists/architect-checklist.md
.aios-core/development/checklists/change-checklist.md
.aios-core/development/checklists/component-quality-checklist.md
.aios-core/development/checklists/database-design-checklist.md
.aios-core/development/checklists/dba-predeploy-checklist.md
.aios-core/development/checklists/dba-rollback-checklist.md
.aios-core/development/checklists/migration-readiness-checklist.md
.aios-core/development/checklists/pattern-audit-checklist.md
.aios-core/development/checklists/pm-checklist.md
.aios-core/development/checklists/po-master-checklist.md
.aios-core/development/checklists/pre-push-checklist.md
.aios-core/development/checklists/release-checklist.md
.aios-core/development/checklists/story-dod-checklist.md
.aios-core/development/checklists/story-draft-checklist.md
.aios-core/development/scripts/approach-manager.js
.aios-core/development/scripts/asset-inventory.js
.aios-core/development/scripts/autonomous-build-loop.js
.aios-core/development/scripts/branch-manager
.aios-core/development/scripts/build-orchestrator.js
.aios-core/development/scripts/build-state-manager.js
.aios-core/development/scripts/git-wrapper
.aios-core/development/scripts/gitignore-manager
.aios-core/development/scripts/gotchas-memory.js
.aios-core/development/scripts/migrate-agent.js
.aios-core/development/scripts/path-analyzer.js
.aios-core/development/scripts/recovery-tracker.js
.aios-core/development/scripts/repository-detector
.aios-core/development/scripts/rollback-manager.js
.aios-core/development/scripts/security-checker.js
.aios-core/development/scripts/stuck-detector.js
.aios-core/development/scripts/version-tracker
.aios-core/development/scripts/workflow-management.md
.aios-core/development/scripts/worktree-manager.js
.aios-core/development/scripts/yaml-validator.js
.aios-core/development/tasks/add-tech-doc.md
.aios-core/development/workflows/qa-loop.yaml
.aios-core/development/workflows/story-development-cycle.yaml
.aios-core/infrastructure/scripts/validate-agents.js
.aios-core/install-manifest.yaml
.aios-core/product/templates/subagent-step-prompt.md
.aios-core/version.json
.antigravity/rules/agents/aios-master.md
.antigravity/rules/agents/analyst.md
.antigravity/rules/agents/data-engineer.md
.antigravity/rules/agents/devops.md
.antigravity/rules/agents/pm.md
.antigravity/rules/agents/po.md
.antigravity/rules/agents/sm.md
.antigravity/rules/agents/squad-creator.md
.antigravity/rules/agents/ux-design-expert.md
.claude/commands/AIOS/agents/aios-master.md
.claude/commands/AIOS/agents/analyst.md
.claude/commands/AIOS/agents/data-engineer.md
.claude/commands/AIOS/agents/devops.md
.claude/commands/AIOS/agents/pm.md
.claude/commands/AIOS/agents/po.md
.claude/commands/AIOS/agents/sm.md
.claude/commands/AIOS/agents/squad-creator.md
.claude/commands/AIOS/agents/ux-design-expert.md
.claude/settings.json
.codex/agents/aios-master.md
.codex/agents/analyst.md
.codex/agents/data-engineer.md
.codex/agents/devops.md
.codex/agents/pm.md
.codex/agents/po.md
.codex/agents/sm.md
.codex/agents/squad-creator.md
.codex/agents/ux-design-expert.md
.codex/skills/aiox-god-mode/SKILL.md
.codex/skills/aiox-god-mode/references/agent-creation.md
.codex/skills/aiox-god-mode/references/agent-matrix.md
.codex/skills/aiox-god-mode/references/component-templates.md
.codex/skills/aiox-god-mode/references/framework-map.md
.codex/skills/aiox-god-mode/references/squad-creation.md
.codex/skills/aiox-god-mode/references/task-creation.md
.codex/skills/aiox-god-mode/references/workflow-creation.md
.codex/skills/aiox-god-mode/references/workflow-playbooks.md
.cursor/rules/agents/aios-master.md
.cursor/rules/agents/analyst.md
.cursor/rules/agents/data-engineer.md
.cursor/rules/agents/devops.md
.cursor/rules/agents/pm.md
.cursor/rules/agents/po.md
.cursor/rules/agents/sm.md
.cursor/rules/agents/squad-creator.md
.cursor/rules/agents/ux-design-expert.md
.env.backup.1773067434555
.env.example
.gemini/commands/aios-analyst.toml
.gemini/commands/aios-data-engineer.toml
.gemini/commands/aios-devops.toml
.gemini/commands/aios-master.toml
.gemini/commands/aios-menu.toml
.gemini/commands/aios-pm.toml
.gemini/commands/aios-po.toml
.gemini/commands/aios-sm.toml
.gemini/commands/aios-squad-creator.toml
.gemini/commands/aios-ux-design-expert.toml
.gemini/rules/AIOS/agents/aios-developer.md
.gemini/rules/AIOS/agents/aios-master.md
.gemini/rules/AIOS/agents/aios-orchestrator.md
.gemini/rules/AIOS/agents/analyst.md
.gemini/rules/AIOS/agents/data-engineer.md
.gemini/rules/AIOS/agents/db-sage.md
.gemini/rules/AIOS/agents/devops.md
.gemini/rules/AIOS/agents/github-devops.md
.gemini/rules/AIOS/agents/pm.md
.gemini/rules/AIOS/agents/po.md
.gemini/rules/AIOS/agents/sm.md
.gemini/rules/AIOS/agents/squad-creator.md
.gemini/rules/AIOS/agents/ux-design-expert.md
.gemini/workflows/qa-loop.md
.github/agents/aios-master.agent.md
.github/agents/analyst.agent.md
.github/agents/data-engineer.agent.md
.github/agents/devops.agent.md
.github/agents/pm.agent.md
.github/agents/po.agent.md
.github/agents/sm.agent.md
.github/agents/squad-creator.agent.md
.github/agents/ux-design-expert.agent.md
.gitignore
custom/fix-request.md
docs/stories/active/CODEINTEL-RP-001.story.md
docs/stories/active/CODEINTEL-RP-001/qa/QA_FIX_REQUEST.md
jest.config.js
tests/integration/workflow-intelligence/pattern-learning.test.js
tests/unit/context-detector.test.js

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions

Welcome to aiox-core! Thanks for your first pull request.

What happens next?

Automated checks will run on your PR
A maintainer will review your changes
Once approved, we'll merge your contribution!

PR Checklist:

Tests pass (npm test)
Linting passes (npm run lint)
Commit messages follow Conventional Commits

Thanks for contributing!

nikolasdehor · 2026-03-11T13:09:25Z

Good work on the RegistryProvider implementation, @Artificiallltda. The code-intel system is a core piece of the framework, and getting the primitives right matters.

Code review of registry-provider.js:

The findReferences() fix (FIX-CIRP-001) is the most important change here. The previous logic was treating usedBy as "this entity references symbol X," but in the AIOS schema, usedBy means "symbol X uses this entity" — the relationship is inverted. The corrected logic now searches dependencies arrays to find which entities depend on the symbol, which is semantically correct. The second pass using usedBy to resolve back-references completes the picture.
Deduplication via seenFiles Set (FIX-CIRP-002) is clean and efficient. Since findReferences() can match both through dependencies and usedBy lookup, the same file could appear twice — the Set prevents that without needing to post-process the array. Good pattern.
The fs.rmSync modernization in tests is a welcome cleanup. The old rmdirSync with manual recursive deletion (unlinking each file, then rmdir-ing each parent) was fragile and verbose.

Concerns about scope:

core-config.yaml has massive deletions (315 lines removed). It looks like the entire MCP configuration, CodeRabbit integration, GitHub settings, utils/helpers lists, ideSync config, autoClaude worktree settings, and synapse session config were stripped. Was this intentional? These are functional configuration blocks that other parts of the codebase may depend on. If this was a config reset for a fresh brownfield install test, it should be reverted before merge, or at minimum documented as a known breaking change.
frameworkProtection: false in core-config.yaml with the comment mentioning "GOD MODE" — this disables the boundary guard that prevents accidental framework file edits. The constitution.md changes adding "GOD MODE" sections (self-critique, enhanced handoff) are interesting, but disabling framework protection in the same PR as a code-intel fix seems like scope creep. These should probably be separate PRs.
The install-manifest.yaml diff shows 4349 deletions — that's a significant reduction. Is this a legitimate trimming of unused manifest entries, or was the file accidentally truncated?
aios-kb.md lost 915 lines (from 921 to 6). Was the knowledge base content moved elsewhere, or is this data loss?

The RegistryProvider code changes themselves are correct and well-tested. I'd recommend isolating the config/manifest changes into a separate PR to keep this one focused on the code-intel story (CODEINTEL-RP-001).

Artificiallltda added 5 commits March 3, 2026 23:33

chore: atualizacao aios-core

b2f04bc

chore: save source code changes

434b1da

fix(code-intel): resolve RegistryProvider logic errors and modernize …

99795ab

…test cleanup (Story CODEINTEL-RP-001)

docs(story): mark CODEINTEL-RP-001 as Done

06ffbaa

Artificiallltda requested review from Pedrovaleriolopez and oalanicolas as code owners March 11, 2026 03:07

github-actions bot reviewed Mar 11, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(code-intel): RegistryProvider implementation (Story CODEINTEL-RP-001)#586

feat(code-intel): RegistryProvider implementation (Story CODEINTEL-RP-001)#586
Artificiallltda wants to merge 5 commits intoSynkraAI:mainfrom
Artificiallltda:feat/codeintel-registry-provider

Artificiallltda commented Mar 11, 2026

Uh oh!

vercel bot commented Mar 11, 2026

Uh oh!

coderabbitai bot commented Mar 11, 2026

Review skipped

Uh oh!

github-actions bot left a comment

Uh oh!

nikolasdehor commented Mar 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Artificiallltda commented Mar 11, 2026

Uh oh!

vercel bot commented Mar 11, 2026

Uh oh!

coderabbitai bot commented Mar 11, 2026

Review skipped

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

nikolasdehor commented Mar 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants