Prepare for experimental implementation of hetero-array support.#293
Prepare for experimental implementation of hetero-array support.#293nachumg wants to merge 1 commit intoSystemRDL:mainfrom
Conversation
We have a working implementation, with many tests. I plan to upstream the functionality in stages along with the relevant tests. This change adds a guard flag that can be easily enabled when running any tool that embeds the compiler.
|
Before merging this change, I would like to better understand the actual approach you took for implementing heterogeneous arrays and whether it fits safely within all the known use-cases. There are numerous possible approaches for this feature so I'd like to know how you did it. Please feel free to reach out to me either on the Matrix chat (https://matrix.to/#/#systemrdl:gitter.im) or via email (amykyta3 at gmail) |
| HETERO_ARRAYS = flags.DEFINE_bool( | ||
| 'experimental_hetero_arrays', | ||
| False, | ||
| 'Support heterogeneous arrays.') |
There was a problem hiding this comment.
This introduces a new package dependency to Google's Abseil library, but with seemingly no benefit. None of the other PeakRDL utilities use Abseil for command line processing, nor is this systemrdl-compiler package a command-line tool.
|
Hi Alex. Our implementation needs refactoring before attempting to upstream. I'll revisit when we have done that. |
|
Again, please see my prior comment about discussing the implementation first. I expect this is a very significant change and will likely not be merged if it is not architecturally robust. |
We have a working implementation, with many tests.
I plan to upstream the functionality in stages along with the relevant tests.
This change adds a guard flag that can be easily enabled when running any tool that embeds the compiler.