Release/1.6.3#21
Merged
Merged
Conversation
…data This is needed for GGG2020.1, at least for users that need to generate GGG2020.1 files on their own. Recently, the Scripps files changed URLs, which broke the auto-update functionality. By being able to download the prepared f(O2) file from tccondata, this solves both the issue of potential future URL changes out of my control and keeping a consistent f(O2) value across all users. However, since this is publishing a product derived from the Scripps data, I'm keeping the data itself behind a password until I'm sure this is okay with Scripps.
Also allowed the tccondata O2 file URL to be set by an environmental variable.
This fixes downloading from Scripps as well as now points the "direct" download to the non-password protected folder on tccondata.org.
This should address #14 pending rerun of unit tests.
Also added a check to ensure that the large files download works
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.