Skip to content

Ensure user comments are confirmed as saved on the Map screen#86

Draft
jravani with Copilot wants to merge 2 commits into
mainfrom
copilot/ensure-user-comments-visible
Draft

Ensure user comments are confirmed as saved on the Map screen#86
jravani with Copilot wants to merge 2 commits into
mainfrom
copilot/ensure-user-comments-visible

Conversation

Copilot AI commented Jun 18, 2026

Copy link
Copy Markdown

Users had no way to verify their feedback comments were received after submission — the app gave no application-level signal of success or failure.

Changes

src/app/App.tsx

  • Added SubmissionToast component: fixed-position, auto-dismissing (6 s) notification rendered on every feedback submission
    • Success: green "✓ Your feedback was saved." with a "View →" link to the created GitHub issue, so users can confirm their comment landed
    • Error: red "✕ Could not save feedback — please try again."
  • Wired onSubmitSuccess / onSubmitError into FeedbackKitProvider — these fire for both session task comments and issue reports
<FeedbackKitProvider
  apiEndpoint="/api/feedback"
  onSubmitSuccess={handleSubmitSuccess}   // shows toast + link to GH issue
  onSubmitError={handleSubmitError}       // shows error toast
>

vite.config.ts

  • Fixed broken build: the @thd-spatial-ai/feedback-kit alias was hard-coded to a local sibling source tree (../feedback-kit/src/index.ts) that doesn't exist in CI. Now checks for that path with fs.existsSync and falls back to the installed npm dist when absent.

- Wire up onSubmitSuccess and onSubmitError callbacks on FeedbackKitProvider
  in App.tsx so that every feedback/comment submission (session task comments
  and issue reports) shows a dismissible toast notification confirming the
  comment was saved, with a direct link to the created GitHub issue.
- Add SubmissionToast component that auto-dismisses after 6 seconds and
  includes a 'View →' link to the GitHub issue for successful submissions.
- Fix vite.config.ts alias for @thd-spatial-ai/feedback-kit to fall back to
  the installed npm dist when the local sibling source tree is absent, so that
  CI/production builds succeed even without the feedback-kit repo checked out.
Copilot AI changed the title [WIP] Fix issue with user comments on Map screen not saving Ensure user comments are confirmed as saved on the Map screen Jun 18, 2026
Copilot AI requested a review from jravani June 18, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants