Open
Conversation
Changes to be committed: new file: "PKU/2022/experience/\344\277\241\346\201\257\345\267\245\347\250\213\345\255\246\351\231\242-\350\256\241\347\256\227\346\234\272\345\272\224\347\224\250\346\212\200\346\234\257-\351\242\204\346\216\250\345\205\215-\346\213\237\345\275\225\345\217\226.md"
skyleaworlder
requested changes
Feb 27, 2023
Member
skyleaworlder
left a comment
skyleaworlder
left a comment
There was a problem hiding this comment.
非常感谢同学的 PR，但个人认为仍然存在一些地方需要修改，大部分与仓库结构有关，如果有时间的话还请同学持续 commit，或者我们也可以讨论怎样更好地展现这份内容。
Member
There was a problem hiding this comment.
仓库的设计是希望想要申请对应学校的同学能够按照仓库目录下的 “学校名” 获取对应信息。将其他夏令营信息掺杂在我看来并不是一种恰当的方式。
Member
There was a problem hiding this comment.
如果有时间精力并且愿意的话，我有个不情之请，不知是否可以麻烦同学每个学校都写一份（
Author
There was a problem hiding this comment.
原来要分开的吗……很多学校细节记不清了，有点不想改…orz
能不能在题目标一下还包括其他学校
Member
There was a problem hiding this comment.
在这里附上 “基本情况” 是非常好的，但个人认为仓库 PKU 目录下 README 中的 “本年度填报情况” 也需要一起附上。
Member
There was a problem hiding this comment.
这里的 注意事项 我认为可以放到学校目录下的 README 中。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to be committed:
new file: "PKU/2022/experience/\344\277\241\346\201\257\345\267\245\347\250\213\345\255\246\351\231\242-\350\256\241\347\256\227\346\234\272\345\272\224\347\224\250\346\212\200\346\234\257-\351\242\204\346\216\250\345\205\215-\346\213\237\345\275\225\345\217\226.md"